Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance MockLink for Multiple ADS-B Vehicle Simulation #12058

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enhance MockLink for Multiple ADS-B Vehicle Simulation #12058

wants to merge 2 commits into from
+68 −28

Conversation

Paschalis
Copy link
Contributor

Description

This PR addresses the limitations of the current MockLink implementation by enabling the simulation of five ADS-B vehicles, providing a more realistic and consistent flight path on the QGroundControl map. The following changes were made:

  • Updated MockLink.cc and MockLink.h to allow the addition of five vehicles that simulate realistic movements and smooth transitions.
  • Ensured that the heading of each ADS-B vehicle aligns with its movement direction, improving the overall accuracy of the simulation.
  • The existing ADSB_Simulator.py script remains in the project to facilitate testing of SDR hardware faults and antenna issues. This redundancy is crucial for users who require a fallback method for ADS-B simulation via TCP link, mimicking a real ADS-B server setup.
Screencast.from.2024-10-30.21-23-23.mp4

Checklist:

Related Issue

#12006

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Paschalis and others added 2 commits October 30, 2024 21:42
@Paschalis
Enhance MockLink to Simulate Multiple ADS-B Vehicles
5d56a68 
- Modified  and  to add functionality for simulating 5 ADS-B vehicles with realistic flight paths.
- Vehicles now move smoothly and their headings align with their movement direction, providing a more accurate representation on the map.
- Retained the existing ADSB_Simulator.py script for redundancy checks on SDR dongles, allowing users to test hardware faults and antenna issues via TCP link like a real ADS-B server.
@Paschalis
Merge branch 'mavlink:master' into master
29bf3cf
@HTRamsey
Copy link
Collaborator

HTRamsey commented Oct 30, 2024 •
edited
Loading

As it seems like you are actively using ADSB, do you think it would be valuable to parse more ADSB messages for the remaining data not currently used in mavlink_adsb_vehicle_t? Like hor_velocity, ver_velocity, tslc, etc

@Paschalis
Copy link
Contributor Author

As it seems like you are actively using ADSB, do you think it would be valuable to parse more ADSB messages for the remaining data not currently used in mavlink_adsb_vehicle_t? Like hor_velocity, ver_velocity, tslc, etc

I agree that parsing additional ADS-B messages would be beneficial. In addition to the mentioned fields, we would like to add:

  • Groundspeed (hor_velocity) in knots.
  • Climbing/Descending Indicator: A small icon (such as ^ for climbing and v for descending) to visually indicate the vertical velocity of the aircraft.
  • Emergency Squawk Status: Indicate emergency squawks (7500, 7600, 7700) with visual markers, such as changing the vehicle icon to a red version, to allow easy identification.

Suggest displaying these details in a hover field when the mouse is over each vehicle, allowing users to access relevant information only as needed.

Additionally, should adding appropriate vehicle images based on aircraft type to help distinguish between planes and helicopters, as discussed on Aviation Stack Exchange.

@HTRamsey
Copy link
Collaborator

Could you make a feature request for that and any other thoughts you have on it? Adding the messages is very quick and easy, visual stuff might take a slight bit more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonLakeFlyer DonLakeFlyer Awaiting requested review from DonLakeFlyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Paschalis @HTRamsey